Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global improvements #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Mar 31, 2020

This PR includes #23 (as it touched composer.json anyway), and :

  • Replace Travis CI by GitHub Actions (much faster feedback loop)
  • Add PHP 7.3 + 7.4 to Travis
  • Bump requirements to PHP 7.1+ and Symfony 4+
  • Bump PHPUnit minimum version needed to run the tests (using ^4.8 does not work as the TestCase class with namespace did not existed back in this version)
  • Remove warning caused by deprecated PHPUnit option (syntaxCheck)
  • Use a local web server to test Data::buildFromUrl() (to prevent network errors in tests)
    • Upgrade sami/sami to ^4.1 (needed to use symfony/process that runs the local web server). I had to remove the theme => enhanced line in sami_configuration.php to run ./buildAPI.sh. However, I did not committed the changes done in the docs in this PR, as it's outside the scope of my knowledge whether the changes would be good or not.

You can see the build (including #23 and #24) passing here : https://github.com/gnutix/PHP-dataURI/pull/2/checks

@gnutix gnutix force-pushed the improve-tests-setup branch from 5b10ac9 to cbe61d8 Compare March 31, 2020 07:42
@gnutix gnutix changed the title Add PHP 7.3 + 7.4 to Travis, remove deprecated PHPUnit option. Improve the tests setup Mar 31, 2020
@gnutix gnutix force-pushed the improve-tests-setup branch from b2c5095 to 4e63025 Compare March 31, 2020 08:06
@gnutix gnutix changed the title Improve the tests setup Global improvements Mar 31, 2020
@gnutix gnutix force-pushed the improve-tests-setup branch from 4e63025 to 0901e94 Compare March 31, 2020 08:11
@williamdes
Copy link

Hi @gnutix
You can replace Sami by Doctum it's fork and you should have no dependencies issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants